-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove craft_command.h and recipe.h from character.h #71183
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
Changes (can be) made in C++. Previously named `Code`
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
labels
Jan 23, 2024
As you can see, it is not as trivial. This is what IWYU says for
|
This is one of the most expensive headers to include, and there is literally no reason for it to be here.
Another header that had no reason to be included in character.h, and was one of the most expensive headers to compile as such.
ehughsbaird
force-pushed
the
easy-header-win
branch
from
January 23, 2024 13:07
a6ff67d
to
389453d
Compare
github-actions
bot
added
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
Code: Tests
Measurement, self-control, statistics, balancing.
labels
Jan 23, 2024
I see. Yeah, not as easy as I thought - it wouldn't have caught this without some digging. |
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[C++]
Changes (can be) made in C++. Previously named `Code`
Code: Tests
Measurement, self-control, statistics, balancing.
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
json-styled
JSON lint passed, label assigned by github actions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
@Brambor asked a question in Discord, which made me look at this https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/7617238475/job/20745814812, which made me look at this:
Describe the solution
Remove the headers, which do not need to be included.
Describe alternatives you've considered
Testing
From
to
Additional context
@Brambor If you've got IWYU running, it'd be great to do it on the whole codebase.